Merge feature/defs-filestore to develop #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryQuan
changed the title
|
It seems that there may be a dead lock somewhere during testing. While running the console version benchmark I have written, this has never happened. |
|
@SakuraIsayeki The deadlock is only happening during the test, not sure what is the reason behind. For now, I have added a TimeOut to prevent this from happening, but we may need a deeper dive in the future. It can be the difference between Debug and Release builds. |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes conflicts with the develop branch. There is one thing to notice.
However, they are still used in def-filestore since it was branched out before the refactor. That's why they are added back. We may need to review DefinitionDirectory & AssemblyDefinitionLoader because they are still dependent.